Not all controller middleware send responses. In this unit test, we’ll verify that a controller’s middleware interacts with the request, response, next function, and database correctly.

Test Node.js Backends

Unit Test Business Logic of a Controller’s Middleware

Instructor: [00:01] For the other extra credit on this one, we're going to test everything else. There are a couple of things that we can pick out of this. I'm going to pick a couple of these other functions to test and a couple of other different cases.

[00:11] We'll start out with the `setListItem`, which we can find right here.

#### list-items-controller.js

```javascript
async function setListItem(req, res, next) {
  const {id} = req.params
  const listItem = await listItemsDB.readById(id)
  if (!listItem) {
    res
      .status(404)
      .json({message: `No `listItem` was found with the id of ${id}`})
    return
  }
  if (req.user.id === listItem.ownerId) {
    req.listItem = listItem
    next()
  } else {
    res.status(403).json({
      message: `User with id ${req.user.id} is not authorized to access the `listItem` ${id}`,
    })
  }
}
```

This one's unique because it's used as a typical middleware, and it calls the `next` function rather than calling `json`.

[00:23] If we take a look at the `listItem`s here where our route is defined, we can see that pretty much all of these thing have an `id` are calling `setListItem` as part of the middleware chain so that each one of these other middlewares doesn't have to bother with looking at the listItem in the database and any of the other controller logic that `setListItem` is doing for us.

#### routes / list-items.js

```javascript
router.get(
  "/:id",
  authMiddleware,
  listItemsController.setListItem,
  listItemsController.getListItem
);

router.post("/", authMiddleware, listItemsController.createListItem);

router.put(
  "/:id",
  authMiddleware,
  listItemsController.setListItem,
  listItemsController.updateListItem
);

router.delete(
  "/:id",
  authMiddleware,
  listItemsController.setListItem,
  listItemsController.deleteListItem
);
```

[00:43] What is that `listItem` doing? Basically, it's taking the `id` off of the `params`.

#### list-items=controller.js

```javascript
const { id } = req.params;
```

It's reading the `listItem` from the database.

```javascript
const listItem = await listItemsDB.readById(id);
```

If there isn't a `listItem`, then it's going to return a `404` with an error message.

```javascript
if (!listItem) {
    res
      .status(404)
      .json({message: `No `listItem` was found with the id of ${id}`})
    return
  }
```

If there is a `listItem`, it's going to check that the `user` who's making this request has the same `id` as the `ownerId` on that `listItem` so that they're authorized.

```javascript
 if (req.user.id === listItem.ownerId) {
    req.listItem = listItem
    next()
  } else {
    res.status(403).json({
      message: `User with id ${req.user.id} is not authorized to access the `listItem` ${id}`,
    })
  }
```

[01:02] If they don't, then you're going to get a `403` with an error message. If they do, then we set the `listItem` on the request object and then continue on the Middleware chain. We can see that we're using that request `listItem` in `getListItem`, `updateListItem` and `deleteListItem`.

[01:20] That's what the purpose of this Middleware is and that's what we're going to be testing first is this little case right here.

Let's make an `async` `test` that is called `setListItem sets the listItem on the req`.

#### list-items-controller.exercise.js

```javascript
test("setListItem sets the listItem on the req", async () => {});
```

Here we're going to need a `user` and we'll need a `listItem`. That is `buildListItem` with that `ownerId` set to the `user.id` so that they're associated here.

```javascript
const user = buildUser();
const listItem = buildListItem({ ownerId: user.id });
```

[01:46] Then in here in our code, we're using listItem`s database,`readById`.

We're going to need to mock this particular module. Let's go up here, we'll add a `mock` for `list-items`.

```javascript
jest.mock("../../db/list-items");
```

Then right here, we'll add `listItem`s and pull this in as `listItemsDb`.

```javascript
import * as listItemsDB from "../../db/list-items";
```

Cool, so now we can come down here and we'll say `listItemsDB.readById.mockResolvedValueOnce` with that `listItem`.

```javascript
listItemsDB.readById.mockResolvedValueOnce(listItem);
```

[02:16] When it's called, it's going to return a promise that resolves to this `listItem`. Now we can make our request object, `buildReq` with a `user` specified and the `params` specified with an `id` of listItem.id.

```javascript
const req = buildReq({ user, params: { id: listItem.id } });
```

We're covering our cases here with `req.params` `id` and `req.user.id`, which matches that `owner.id` of the `listItem` that we have here.

[02:41] Now, we're going to make a response which is going to be `buildRes`, just a regular response. Our `next` is going to be `buildNext`. `buildNext` hasn't been pulled in yet. Let's bring that in right here. Great.

```javascript
const res = buildRes();
const next = buildNext();
```

[02:53] Now we can `await` `listItemsController.setListItem` with the request response and `next`.

```javascript
await listItemsController.setListItem(req, res, next);
```

We'll verify that the `listItemsDB` `toHaveBeenCalledWith`...What has it called with? Let's take a look. The `readById` `id`. The `req.params` `id` here.

#### list-items-controller.js

```javascript
const { id } = req.params;
const listItem = await listItemsDB.readById(id);
```

[03:12] That needs to be that `listItem.id`. Let's see., `listItem.id`. We'll also expect that to have been called times once and only once. We'll expect that `next` to have been called with...What is that called with here? Called with `nothing`.

```javascript
expect(listItemsDB).toHaveBeenCalledWith(listItem.id);
expect(listItemsDB).toHaveBeenCalledTimes(1);

expect(next).toHaveBeenCalledWith(/* nothing */);
```

[03:30] Actually, it is important that we verify that it is called with `nothing`. If it's called with something, then that is actually going to trigger an error and express middleware. We want to verify that it's actually called with `nothing`.

[03:41] We could be more explicit here and just be like `nothing`, just to say this isn't an accident, we literally want to make sure that it's called with `nothing`. Then we'll say it's called the times once.

```javascript
expect(next).toHaveBeenCalledTimes(1);
```

[03:52] Finally, we want to make sure that the `req.listItem` is set properly. We can `expect` `req.listItem` to be our `listItem` that we created and returned from our `mockResolvedValueOnce`.

```javascript
expect(req.listItem).toBe(listItem);
```

We save that. It looks like our test is actually failing.

![Failing Test](https://res.cloudinary.com/dg3gyk0gu/image/upload/v1575572533/transcript-images/16_scikit-learn-test-controller-404-edge-case-where-resource-is-not-found-passing.jpg)

The reason it's failing is because I made a mistake right here. This needs to be `readById`.

```javascript
expect(listItemsDB.readById).toHaveBeenCalledWith(listItem.id);
expect(listItemsDB.readById).toHaveBeenCalledTimes(1);
```

There we go. Save that, and now our test is passing. Excellent.

![Test Passing](https://res.cloudinary.com/dg3gyk0gu/image/upload/v1575572534/transcript-images/15_scikit-learn-unit-test-business-logic-of-a-controller-s-middleware-test-passing.jpg)

[04:18] Let's take a look here and make sure that we're covering our bases. We have the `setlistItem` which takes a request response, and the `next` we pluck off the `id` from `req.params`. We read that id from the `listItemsDB`. With that `listItem`, we check the `ownerId` is the same as the `req.user.id`. If it is, then we set that `listItem` on the request and call `next`.

```javascript
async function setListItem(req, res, next) {
  const {id} = req.params
  const listItem = await listItemsDB.readById(id)
  if (!listItem) {
    res
      .status(404)
      .json({message: `No list item was found with the id of ${id}`})
    return
  }
  if (req.user.id === listItem.ownerId) {
    req.listItem = listItem
    next()
  } else {
    res.status(403).json({
      message: `User with id ${req.user.id} is not authorized to access the list item ${id}`,
    })
  }
```

[04:38] That's what we're verifying here. We have to create that fake `user` and that `listItem` that is associated to that `user`. We make sure that the `listItem`s database `readById` method returns a promise that resolves to the `listItem`. Then we create a request object that has the `user` on it, as well as the `params` for that `listItem.id`, and then a normal response object, and a normal `next` function.

[05:00] We pass those along to `setListItem`. Then we verify that the `listItemsDB.readById` was called with the `listItem.id`, and that it was called only one time. We verified that `next` was called with `nothing` and that it was called one time. We expect that the `req.listItem` to be `listItem`.

[05:18] That's really what we're trying to get across here with all these tests is that this `setListItem` sets the `listItem` on the request.


Backends hold so much of our application's business logic that is often used to support multiple clients (web, mobile, and other native platforms). This logic is critical to get right and deploying a breaking change to this can be devastating to your company's goals (not to mention the bottom-line). Increasing your "deployment confidence" is crucial and automated testing is the best way to do that.

As Node.js continues to grow in usage around the world, learning how to test this mission-critical code in a way that increases developer velocity as well as confidence becomes increasingly important. In this workshop we use an Express.js example and focus on the patterns and practices that you need to learn so you can apply what you learn to test your code written in any Node.js web framework.

You'll learn:

Intro to Test Node.js Backends

Of all things you can test, the easiest thing you can test is a pure function because they require no setup or teardown. In this exercise, we’ll explore testing a pure function called isPasswordAllowed.

Test Pure Functions Overview

Let’s write the basic tests for our simple isPasswordAllowed function to ensure that both valid and invalid passwords receive the correct return value.

Write Unit Tests for a Simple Pure Function

One of the most crucial things you can do when writing tests is ensuring that the error message explains the problem as clearly as possible so it can be addressed quickly. Let’s improve our test by generating test titles so error messages are more descriptive.

Improve Error Messages by Generating Test Titles

Jest has a test-generation feature built-in called test.each which is great, but I don’t particularly like it’s API. Instead, we’re going to use an open source project called jest-in-case which gives us a really nice API for generated tests and improved error messages. Let’s try that library out for our isPasswordAllowed tests here.

Use jest-in-case to Reduce Duplication and Improve Test Titles

Even with jest-in-case there can be a little boilerplate and you can easily side-step that by creating a simple function that allows you to write test cases that are more suited for your use case. Let’s give that a try!

Create a Casify Function to Generate Cases for jest-in-case

There are various types of middleware and for many of them you write tests for them in the same way, so let’s get a look at one of these and try our hand at writing some tests for it.

Test Node Middleware Overview

We have an error middleware in our app for handling uncaught errors throughout our application. Let’s write our first test case for handling an UnauthorizedError which our authentication abstraction throws when someone attempts to access data they shouldn’t.

Write a Unit Test for Handling an UnauthorizedError

Our next test will be really similar to the first. This time we want to handle the case where a response has already been sent which you know if the res.headersSent property is set. So we’ll add that property to our fake response object and verify the middleware behaves correctly.

Write a Unit Test for Handling headersSent in an Error Middleware

Our final case is the fallback scenario where we don’t know exactly why things are failing. In this situation we’ll just give all the information that we can and hopefully the developers can figure out what that is. Let’s write a test case for that situation.

Write a Unit Test for Status 500 Error Middleware Fallback

We’ve got a little bit of duplication between these tests and in a more complex middleware we’ll have a lot of duplication. The duplication itself isn’t necessarily problematic. The problem comes in the form of readability of our tests. When there’s a great amount of duplication, it makes it harder to identify the parts of the test that distinguishes it from other tests. In this lesson we’ll apply the object factory pattern to reduce duplication and make it easier to maintain our tests.

Improve Test Maintainability using the Test Object Factory Pattern

We’re going to need the same utilities for our object factories in several places in our tests, so let’s use some pre-built utilities instead of the ones we wrote for this file.

Use a Test Object Factory utils/generate

Controllers are a collection of middleware that applies business logic specific to your domain. Typically these are tested like any other middleware, but often they require mocking the database for unit tests.

Test Node Controllers Overview

Let’s write our first controller middleware unit test by mocking out a database call and verifying that the database is interacted with correctly and the response is sent correctly.

Write a Unit Test for a Controller by Mocking the Database

Let’s add a test for an edge case that responds with an error message. In this lesson we’ll talk about the value of using the toMatchInlineSnapshot assertion for error messages.

Simplify Assertions on Error Messages with toMatchInlineSnapshot

Sometimes people try to access data that’s not there and it would be great if our server doesn’t fall over when they do, so we have some code to handle that case. Let’s get that tested and use toMatchInlineSnapshot for asserting on the error message.

Test Controller 404 Edge Case where Resource is Not Found

If the user tries to access a resource they shouldn’t have access to, we need to make sure they can’t get that resource, and we’ll want a test to make sure that functionality doesn’t break because this is a data security concern. In this one we handle dynamic data in a snapshot by making a consistent ID for the user and list item.

Test Controller Unauthorized Case

We have another controller function we want to test that will retrieve all of the user’s list items. For this one we’ll need to mock out a few new APIs and build multiple books and list items. Then we’ll have to do a few things to ensure that the APIs were called correctly.

Test getListItems for Getting Multiple Mock Objects

We want to test the createListItem controller function so we can ensure that users can create new list items. In this one we need to mock out several database requests. We also see how great Jest error output is which helps us identify a few mistakes that we made really easily.

Test the Happy Path of a Creation Flow

Even though your edge cases don’t run as often as your happy path cases, they are important to test to make sure you handle those correctly. In this one we’ll verify that if a user attempts to create a new list item for a book even though they already have a list item for that book.

Testing an Error Case for createListItem

For this one, we’ll need to have an existing listItem and we’ll create some new notes for it. Then we’ll have the original list item and the updated list item and ensure that our API is being called with the right version of the list item.

Testing the Happy Path for updateListItem

This one’s a bit unique because it’s pretty simple. All we need to do here is verify that the remove method of our was called properly, but we don’t need to bother mocking out what it returns because our code doesn’t use that return value. We also want to verify that the res.json was called properly, so we’ll do that as well.

Testing Resource Deletion

Let’s start doing some server integration tests. We’ll get our server started and database going so we can hit the endpoints in the same way clients will be using our endpoints. Let’s explore how our app is started so we can start it in our test environment and I’ll show you around the codebase so you can navigate around while you test things out.

Test Authentication API Routes Overview

Let’s get our test ready to roll by getting our API server and database started and in a clean state. Because our tests and server both run in node, we can do this all using the utilities that Jest exposes for us like beforeAll and afterAll. Then we’ll get a test started and fire a request to the API to make sure we can communicate with the server.

Start a Node Server and Fire a Request to an HTTP API Endpoint

When you’re interacting with the API response of a server, some of the data you receive is information that you cannot assert on directly. In this lesson we’ll talk about how to use Jest’s asymmetric matchers to assert on the type of data your server is sending.

Make Assertions on HTTP API Responses for Registration

Let’s make another request in this same test to the login endpoint with the same post data as we used for registration. Then we can verify that the information we retrieved from the registration request is the same as the information we retrieved from the login request.

Test the Login Endpoint for a Node Server

Our server has an API for authenticated clients to request information for the currently logged in user. Let’s make an authenticated request using the user token we retrieved from the login request to get confidence that the token generated will get the data for the user.

Test the User’s Resource Endpoint

We’ve got a bit of duplication in our test for each request and it’d be nice to remove that, so we’ll create a pre-configured axios client to reduce that duplication.

Create a Pre-configured axios Client for the baseURL

If our request fails, the error message is really useless. The server sends us back a much more useful error message, but by default Jest wont display that error properly and we can’t identify the line of code that made the failing request. Let’s use a custom axios interceptor which will improve those error messages considerably by displaying the response that the server returned.

Improve Error Messages with an axios Interceptor

If you want to run your tests in parallel and each of your tests starts up the server on its own, then you could run into a problem where two servers try to bind to the same port. To avoid this, we can use the JEST_WORKER_ID environment variable so we can ensure that the port our server starts on is unique. Let’s try that out.

Ensure a Unique Server Port

Let’s test the case where we try to register two users of the same username. We’ll first register a user, and then we’ll attempt to register a second user with the same username and assert on the error message. We’ll use toMatchInlineSnapshot on the error that’s returned and Jest will serialize that like a champ.

Use Snapshots to Assert on Server Error Responses

Often in integration tests you’ll have situations where you are over testing. Sometimes that’s acceptable, but you can speed up your tests by getting your application into a testable state a little quicker. In this lesson we’ll skip hitting the API for our setup and instead interact directly with the database.

Interact Directly with the Database

Integration tests are typically best for common cases and you can cover other cases using lower level tests, but I thought it’d be interesting to show you how to cover a few other edge cases as well in this lesson.

Test all the Edge Cases

Things change a little bit when we want to hit an endpoint that requires the user to be authenticated. For this exercise you’ll need to use an authenticated test with a test user that’s already in the database. Then you can use that test user for each of the operations you do on the list item resource (Create, React, Update, Delete).

Test CRUD API Routes Overview

Let’s get a test user and authenticated axios client, and then we’ll need to generate a book and insert that into the database directly so we can create a list item for our test user for that book. Then we can verify that the response data is correct.

Write an Integration Test for a Resource Create Endpoint

Now that we’ve created a list item, let’s try to read that list item. This will give us confidence that the list item we created was actually saved to the database and can now be retrieved.

Write an Integration Test for a Resource Read Endpoint

For the update, we’ll need to create new notes for our list item and send those updates to the updates endpoint. Then we can verify that the response we get back is the same as the original list item except with the updated notes.

Integration Test a Resource Update Endpoint

For our delete endpoint, we don’t need to do too much beyond hitting the endpoint, but it could be problematic if we just hit the endpoint and verify the response. In this lesson we’ll find out why that is and how we can use our test to make sure that the item was actually deleted from the database.

Integration Test a Resource Delete Endpoint

Typically, it’s nicer to use toMatchInlineSnapshot for error messages, but sometimes the contents of the error message are generated. But I’ve got a little trick for solving this problem that you’ll probably find useful.

Unit Test Business Logic of a Controller’s Middleware

Transcript

Unit Test Business Logic of a Controller’s Middleware